Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.2] Background group name use a variable #3658

Merged
merged 1 commit into from
Mar 15, 2018
Merged

[2.2] Background group name use a variable #3658

merged 1 commit into from
Mar 15, 2018

Conversation

llienher
Copy link
Member

Backport #3656 into 2.2

@llienher llienher requested a review from ger-benjamin March 15, 2018 08:06
ger-benjamin
ger-benjamin requested changes Mar 15, 2018
View reviewed changes
Copy link
Member

@ger-benjamin ger-benjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not in prototype !

@llienher llienher force-pushed the 2.2-background-group-name branch from 8839352 to e365c0d Compare March 15, 2018 08:11
@llienher
Copy link
Member Author

@ger-benjamin Fixed.

@llienher llienher merged commit fe024b9 into 2.2 Mar 15, 2018
@llienher llienher deleted the 2.2-background-group-name branch March 15, 2018 08:58
@llienher llienher changed the title Background group name use a variable [2.2] Background group name use a variable Mar 15, 2018
@sbrunner sbrunner added this to the 2.2 milestone Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ger-benjamin ger-benjamin ger-benjamin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2.4
Development

Successfully merging this pull request may close these issues.
3 participants
@llienher @ger-benjamin @sbrunner