Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add maxzoom for permalink search #3648

Merged
merged 1 commit into from
Mar 12, 2018
Merged

Add maxzoom for permalink search #3648

merged 1 commit into from
Mar 12, 2018

Conversation

llienher
Copy link
Member

Fixes #3551

Add a new permalink parameter "search-maxzoom" that takes a integer. It does the same behavior as using the gmf-search-maxzoom from the directive, but for permalink. Also remove conflicts with the directive in abstract.js.

@llienher llienher self-assigned this Mar 12, 2018
@llienher llienher requested a review from pfirpfel March 12, 2018 09:16
@pfirpfel pfirpfel requested a review from sbrunner March 12, 2018 09:22
@llienher llienher force-pushed the permalink-search-maxzoom branch from 284736f to 3ebc2e9 Compare March 12, 2018 09:31
Copy link
Contributor

@pfirpfel pfirpfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@llienher llienher force-pushed the permalink-search-maxzoom branch from 3ebc2e9 to a940847 Compare March 12, 2018 09:50
@llienher llienher force-pushed the permalink-search-maxzoom branch from a940847 to 4fa181b Compare March 12, 2018 10:36
@llienher llienher merged commit 4957daf into 2.2 Mar 12, 2018
@llienher llienher deleted the permalink-search-maxzoom branch March 12, 2018 11:09
@sbrunner sbrunner added this to the 2.2 milestone Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants