Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can set preload value of Tiles (default to 0) #3583

Merged
merged 2 commits into from
Feb 27, 2018

Conversation

ger-benjamin
Copy link
Member

@ger-benjamin ger-benjamin self-assigned this Feb 27, 2018
@fredj
Copy link
Member

fredj commented Feb 27, 2018

preload option should simply be removed

Copy link
Member

@gberaudo gberaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ger-benjamin
Copy link
Member Author

(done with the Github editor ! )

@ger-benjamin ger-benjamin merged commit 8e06975 into camptocamp:2.2 Feb 27, 2018
@ger-benjamin ger-benjamin deleted the Set_tile_preload branch February 27, 2018 13:39
@sbrunner
Copy link
Member

I think this this bag :-(, this is to have better performance when we zoom out ...

@sbrunner
Copy link
Member

In this ticker we don't see anything about preload?
Whant's the deference in therm of loading?

@ger-benjamin
Copy link
Member Author

Even on bad internet connection, the change is near invisible on the map, and the tiles around (90% of what you have under your eyes) must be loaded in every cases.

But on the initial load, that a lot of useless tile to load. In the cases of Basel, we load 2.3 Mo of tiled on a total of 4.5Mo (total size of initial load).

If you want, I can (re-)add a configuration value for this parameter. But with fredj and gberaudo , we though that's useless.

@sbrunner
Copy link
Member

I just do a test with slow 3g,
An in booth case (tested on github.io 2.2/master) I get all the visible background in about 55s.
and when I zoom out on 2.2 it takes 23s. and on master 13s.
Then in therm of performance we should keep it, and if it's relay wanted we should add an option and the preload should be infinity by default ...

@ger-benjamin
Copy link
Member Author

ger-benjamin commented Feb 28, 2018

I get all the visible background in about 55s.

More like in 55s for master and 51s in 2.2 for me. And in Basel, they load two background in the same time (one for basel, their tiles, and another for the whole switzerland (Swisstopo)). So, that make ~6-8 sec difference. And that's on the startup, so the slower part of our application. Each optimization on this part is interesting for our users.

But ok. I'll do a configuration value for that, defined to Infinity by default.

@sbrunner
Copy link
Member

Thanks :-)

@sbrunner sbrunner added this to the 2.2 milestone Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants