Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] change dependency to psycopg2 (rather than psycopg2-binary) #73

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

vincent-hatakeyama
Copy link
Contributor

No description provided.

@gurneyalex
Copy link
Member

any reason why?

@vincent-hatakeyama
Copy link
Contributor Author

When psycopg2 is installed and compiled from source, pip check complains that marabunta requires psycopg2-binary and that the dependency is not satisfied.

psycopg2 documentation also recommends using psycopg2-binary for non production environment only.

@oerp-odoo
Copy link

But when you don't have psycopg2 installed from source, then I think it will fail? I remember having some issues with it and switched to psycopg2-binary (on some other packages).

@vincent-hatakeyama
Copy link
Contributor Author

Yes, installing psycopg2-binary will not satisfy psycopg2.

The psycopg2 documentation indicates:

If you are the maintainer of a published package depending on psycopg2 you shouldn’t use psycopg2-binary as a module dependency. For production use you are advised to use the source distribution.

marabunta is installed with the proposed fix alongside psycopg2 and works as expected in production.

@gurneyalex gurneyalex merged commit 7457280 into camptocamp:master Aug 19, 2024
@vincent-hatakeyama vincent-hatakeyama deleted the fix-psycopg2-dependency branch August 26, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants