Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Waitress support for production #2541

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Add Waitress support for production #2541

merged 2 commits into from
Dec 11, 2024

Conversation

sbrunner
Copy link
Member

@sbrunner sbrunner commented Nov 22, 2024

With Gunicorn, we get one main process and one worker process. When the worker is killed the Pod steel alive!

Add resource metrics
Add psutil memory info metrics

@sbrunner sbrunner changed the title Waitress ressource Add Waitress support for production Nov 22, 2024
@sbrunner sbrunner force-pushed the waitress-ressource branch 28 times, most recently from c19ab9e to 5290824 Compare November 25, 2024 12:23
@sbrunner sbrunner force-pushed the waitress-ressource branch 4 times, most recently from f4169ad to 1e3cafb Compare November 25, 2024 12:45
@sbrunner sbrunner marked this pull request as ready for review November 25, 2024 13:09
@ger-benjamin
Copy link
Member

ger-benjamin commented Dec 2, 2024

Can you please add a ticket reference and maybe some historic/reasons of this change for our understanding and TS ?

@sbrunner
Copy link
Member Author

sbrunner commented Dec 2, 2024

@ger-benjamin you can timesheet in https://camptocamp.atlassian.net/browse/GSGMF-1747 :-)

@arnaud-morvan
Copy link
Member

Not sure to understand why we need to duplicate the app, I'm used to switch from gunicorn to waitress just by changing the docker container command.

Add resource metrics
Add psutil memory info metrics
@sbrunner
Copy link
Member Author

sbrunner commented Dec 5, 2024

@arnaud-morvan I updated the README to clarify this point :-)

README.md Outdated Show resolved Hide resolved
acceptance_tests/tests/docker-compose.yaml Outdated Show resolved Hide resolved
@sbrunner sbrunner merged commit 38e4654 into master Dec 11, 2024
7 checks passed
@sbrunner sbrunner deleted the waitress-ressource branch December 11, 2024 14:54
@sbrunner
Copy link
Member Author

Thanks @arnaud-morvan :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants