Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spotifyのライブラリをv2に更新 #241

Merged
merged 3 commits into from
Jan 23, 2022
Merged

Spotifyのライブラリをv2に更新 #241

merged 3 commits into from
Jan 23, 2022

Conversation

p1ass
Copy link
Member

@p1ass p1ass commented Jan 8, 2022

Related Issue

なし

What

  • Spotifyのライブラリをv2にアップグレード
  • Contextを渡せることになったことにより、HTTPリクエストが終了しても続く goroutineループ内でSpotify APIを叩くと、Contextがキャンセルされるようになってしまった
    • これを回避するためにgoroutineで呼ばれる関数で新たにcontextを作ることで、HTTPrクエストが終わってもキャンセルされないようにする

Memo

@p1ass p1ass self-assigned this Jan 8, 2022
@codecov
Copy link

codecov bot commented Jan 8, 2022

Codecov Report

Merging #241 (7e76396) into master (2b3cb68) will decrease coverage by 0.43%.
The diff coverage is 0.00%.

❗ Current head 7e76396 differs from pull request most recent head dbd7ad4. Consider uploading reports for the commit dbd7ad4 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #241      +/-   ##
==========================================
- Coverage   47.48%   47.04%   -0.44%     
==========================================
  Files          34       34              
  Lines        1508     1522      +14     
==========================================
  Hits          716      716              
- Misses        746      760      +14     
  Partials       46       46              
Impacted Files Coverage Δ
domain/service/auth.go 51.85% <0.00%> (-35.65%) ⬇️
usecase/auth.go 0.00% <0.00%> (ø)
usecase/session_timer.go 31.77% <0.00%> (-0.17%) ⬇️
web/sessionToken_middleware.go 66.66% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 135e2ca...dbd7ad4. Read the comment docs.

Copy link
Member

@dora1998 dora1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがたや
ざっと見た感じ大丈夫そうだけど、さんぽしくんにもできれば見てほしさ 🙏

Copy link
Member

@sanposhiho sanposhiho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

動かして試してみてはないけど大体良さそうな気がするのでヨシ!

domain/service/auth.go Outdated Show resolved Hide resolved
@p1ass p1ass merged commit 5d527eb into master Jan 23, 2022
@p1ass p1ass deleted the bump-spotify-library branch January 23, 2022 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants