Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rundeckの代わりにgithub action上でデプロイやる #201

Closed

Conversation

sanposhiho
Copy link
Member

@sanposhiho sanposhiho commented Nov 3, 2020

Related Issue

#200

What

Memo

一旦実験中

@codecov
Copy link

codecov bot commented Nov 3, 2020

Codecov Report

Merging #201 into master will decrease coverage by 1.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #201      +/-   ##
==========================================
- Coverage   48.78%   47.61%   -1.17%     
==========================================
  Files          33       33              
  Lines        1691     1491     -200     
==========================================
- Hits          825      710     -115     
+ Misses        820      735      -85     
  Partials       46       46              
Impacted Files Coverage Δ
domain/entity/user.go 33.33% <0.00%> (-11.12%) ⬇️
database/database.go 55.55% <0.00%> (-4.45%) ⬇️
web/deploy_preview_cors_middleware.go 13.15% <0.00%> (-3.51%) ⬇️
domain/service/auth.go 87.50% <0.00%> (-3.41%) ⬇️
domain/entity/sync_check_timer.go 24.59% <0.00%> (-2.44%) ⬇️
database/auth.go 82.69% <0.00%> (-2.31%) ⬇️
database/session.go 72.41% <0.00%> (-2.21%) ⬇️
database/user.go 86.84% <0.00%> (-1.53%) ⬇️
usecase/session_timer.go 31.93% <0.00%> (-1.40%) ⬇️
web/ws/hub.go 86.11% <0.00%> (-1.13%) ⬇️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49738e0...aa70b2a. Read the comment docs.

@sanposhiho
Copy link
Member Author

失敗したと思ったらsecret登録してなかった
明日やる

@sanposhiho
Copy link
Member Author

envをsecretに入れる必要がある

@p1ass
Copy link
Member

p1ass commented Nov 10, 2020

docker imageのbuildもGitHub Actionsでやらんとやね

@sanposhiho
Copy link
Member Author

太古のブランチすぎて覚えてないのでclose

@sanposhiho sanposhiho closed this Dec 31, 2020
@p1ass p1ass deleted the replace-deploy-flow-rundeck-to-githubaction branch January 1, 2021 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants