66 grade report scaffolding #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- created `ReportCardGradeCycle` and `ReportCardGradeSubject` schemas in `Reporting` context - added `list_report_card_grades_subjects/1`, `add_subject_to_report_card_grades/1`, `update_report_card_grades_subjects_positions/1`, `list_report_card_grades_cycles/1`, and `add_cycle_to_report_card_grades/1` to `Reporting` module - added `update_positions/2` to `Lanttern.Utils` for DRY reasons - added basic grades tab in report card live view
- added `delete_report_card_grade_subject/1` and `delete_report_card_grade_cycle/1` to `Reporting` module - added "primary" theme to badges components
- adjusted text color in primary badge theme
- created `LantternWeb.PersonalizationHelpers` with `assign_user_filters/3` function, reusing the logic implemented in `LantternWeb.CurriculumComponentLive`
- added support to filter by cycle and year in `Reporting.list_report_cards/1` (and added opts to `Reporting.list_report_cards_by_cycle/1`) - added default order by in `Schools.list_cycles/1` - added support to cycles in profile settings - created core `<.filter_text_button>` component - in `LantternWeb.PersonalizationHelpers`: added support to cycles in `assign_user_filters/3`, created `handle_filter_toggle/3`, `clear_profile_filters/2`, and `save_profile_filters/3` - deleted `Taxonomy.SubjectPickerComponent` and `Taxonomy.YearPickerComponent` in favor of `BadgeButtonPickerComponent` - added cycle and year filters to report cards view - adjusted active views in menu
- added `Reporting.get_grade_report/2` - created `Reporting.GradeReportFormComponent`
- refactor: renamed `GradeReport` schema to `GradesReport` (gradeS). all function names and database were updated to align with the new name - added grades report cycles and subjects schemas and functions to `Reporting` context, based on existing report card grade cycles and subjects (which will be removed soon) - added grades report cycles and subjects management UI in grading view
- added suport to `:load_grid` opt in `Reporting.list_grades_reports/1`
- added support to `:load_grid` opt in `get_grades_report/2` and `get_grades_report!/2` in `Reporting` context - moved `<.grades_report_grid>` component to shared module `LantternWeb.ReportingComponents`
…hemas removed schemas, tables, and related functions and UI. schemas removed in favor of `GradesReportCycle` and `GradesReportSubject`.
keep the current tab when editing report card overlay
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.