i18n #48
Merged
i18n #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- created `LantternWeb.Localization` module to update locale option on live views using `on_mount` hook - added `current_locale` to `Profile` - adjusted `Identity.build_flat_profile/1` to add name and school attrs to the existing profile instead of creating a new profile struct manually - added `on_dismiss` attr to `<.error_block>` component - added `pt_BR` locale to project (and some initial translations for menu)
- renamed `LantternWeb.Localization` to `LantternWeb.LocalizationHelpers`, and added `translate_struct_list/4` function - added translations to `<.flash_group>` component - added translations to `<.markdown_supported>` component - created `schools` and `taxonomy` domain translations (not available at compile time)
- fixed fkey constraints in delete changeset for `Activity` and `Strand` schemas
- added `LocalizationHelpers.put_locale/2` plug to `:browser` pipeline - removed locale related code from `:fetch_current_user` plug - created `LocalizationHelpers.get_html_lang/0` to get current backend locale and format it to add to html tag - adjusted menu component to `redirect` instead of `push_navigate` on language change to update html tag lang attr
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there are a lot of places where I didn't added the
gettext()call, but the main goal of this PR was the i18n setup.I've added some code to keep track of the profile locale preference, and restore it in live and dead views.