Strand cover image #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added "white" button theme (core components) - adjusted `<.error_block>` to allow more flexible render slot options - added `error_to_string/2` to `LiveComponentHelpers` for friendlier file upload error messages
- created Supabase uploader - added loading state to `<.button>` when `phx-submit-loading`
…" Elixir using https://github.com/zoedsoupe/supabase lib - removed js uploaders code - removed `external` config in `StrandFormComponent` in favor of upload in `consume_uploaded_entries` - created `LantternWeb.SupabaseHelpers`
|
note for the future: I started the external image upload implementation following this Phoenix LiveView guide, but I switched to a "full Elixir" approach using https://github.com/zoedsoupe/supabase. that being said, if we decide to move back to the external + js approach, the commit a02a5d9 may help |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.