Manage strands #28
Merged
Manage strands #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adjusted `<.input>` component to not render the label at all (instead of rendering it empty) when n o label attr is present - added support to label in `CurriculumItemSearchComponent` - created `LantternWeb.SharedLive.MultiSelectComponent` as an alternative to multi select fields, but with different UX using badges - replaced `LantternWeb.Admin.StrandLive.FormComponent` with `LantternWeb.StrandLive.StrandFormComponent`
- adjusted `activities_strand_id_fkey` constraint to prevent delete cascade activities when deleting strands
…ponent - added `:size` and `:rounded` attrs to `<.button>`
- created `LantternWeb.LiveComponentHelpers` module with 3 initial utilities: `notify_parent/3`, `notify_component/3`, and `handle_navigation/2` - redesigned `LantternWeb.Admin.ActivityLive.FormComponent` into `LantternWeb.StrandLive.ActivityFormComponent` - removed `LantternWeb.NotifyHelpers` imports (notify helpers are loaded in all live components through `LiveComponentHelpers`)
- adjusted `activities_assessment_points_activity_id_fkey` constraint to prevent delete cascade assessment points when deleting activities
- adjusted position definition in `Assessments.create_activity_assessment_point/2` - removed notification calls from `ActivityAssessmentPointFormComponent` in favor of `handle_navigation/2` - added `handle_navigation/2` to `ClassFilterFormComponent` save, passing classes ids as arg - removed all `handle_info` from `StrandLive.Activity` (at least the ones related to patch and navigation, in favor of `handle_navigation` in forms) - added empty state to `StrandLive.List` - added debounce and `handle_navigation/2` on save to `StrandFormComponent` - removed notification calls from `ActivityTabs.AssessmentComponent` in favor of local patch/navigate - adjusted broken seeds.exs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.