Activity assessment #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- created `ActivityAssessmentPoint` schema in `Assessments` context - added `list_activity_assessment_points/1` and `create_activity_assessment_point/2` to `Assessments` - created `LantternWeb.AssessmentPointLive.ActivityAssessmentPointFormComponent` live component - adjusted `Note`'s strand and activity fields to use `belongs_to` with `define_field: false`
activities will be linked to curriculum through activites assessment points
…alization.ProfileView` - deleted `Explorer` context - dropped assessment point filter views tables in favor of new profile views ones (and migrated all the data from one to another)
- created `Curricula.list_strand_curriculum_items/1` - moved `StrandCurriculumItem` to `Curricula` context - added render clause for `<.input type="radio">`
- created `Assessments.ActivityAssessmentGrid` struct
…dering - created `AssessmentPointLive.EntryEditorComponent` based on `AssessmentPointLive.AssessmentPointEntryEditorComponent`
- removed `Assessments.build_activity_assessment_grid/1` in favor of `Assessments.list_activity_students_entries/1` - added `Assessment.get_assessment_point/2` - added `Assessments.delete_assessment_point_and_entries/1` - added edit support to `ActivityAssessmentPointFormComponent` - renamed some components adding `Component` (`_component`) suffix
changed the reference for the `scale_id` field to `assessment_points.scale_id`, to enforce same scale in assessment points and entries are in sync - added line clamp to `<.icon_with_name>` component - adjusted checked attr in `<.input type="radio">` to support both string and int values
- created `Assessments.update_activity_assessment_points_positions/2` (and adjusted the functions order in `Assessments` context file - created `<.icon_button>` component - adjusted how `StrandLive.ActivityTabs.AssessmentComponent` handles assessment point create/update/delete (basically removing the logic from the live component and delegating to parent view, which will trigger a push_navigate and refresh the component)
…red by class - added `:classes_ids` opt to `Assessments.list_activity_students_entries/2` - added `:classes_ids` and `:preload` opts to `Schools.list_user_classes/2` - created `LantternWeb.Helpers.NotifyHelpers` to centralize `notify_parent` and `notify_component` calls (we need to replace local implementations with the helper yet) - created `SchoolLive.ClassFilterFormComponent`
- fix: removed duplicated id issues from `EntryEditorComponent` (removed hidden fields and merged entry fields to param programatically before save) - created `Curricula.list_activity_curriculum_items/2` and implemented it in activity details tab, preventing holding unnecessary intermediate join structs in memory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.