Assessment point rubric #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added `"/assessment_points/:id/rubrics"` router - added empty overlay in assessment point details live view - created `<.badge_button>` component and `get_badge_button_styles/1` and `get_badge_icon_styles/1` support functions to core_components
- added `:is_differentiation` and `:scale_id` opts to `Rubrics.list_rubrics/1` - added assessment point/rubric relationship (DB and schema) - fix: custom `<.label>` conditional render - created `LantternWeb.RubricsHelpers` module, with `generate_rubric_options/1`
- added `LantternWeb.RubricsLive.FormComponent` to assessment point details view and added `handle_info/2` to handle rubric creation - added support to hide differentiation and scale fields, add wrapper class, conditional patch, and show submit button to `LantternWeb.RubricsLive.FormComponent` - added support to handle new rubric with selected scale in `LantternWeb.RubricsLive.FormComponent`
- adjusted initial `handle_params/3` for assessment point rubric route - added `is_differentiation: false` to rubric creation in assessment point view (this was already happening by default, but it's better to make it explicit)
…etails view to its own live component - added support to `notify_component` in `LantternWeb.RubricsLive.FormComponent` using `send_update/3`
- created `LantternWeb.NavigationComponents` module with `<.person_tab>` component and added it to `LantternWeb`'s `html_helpers/0` - added support to `:size` and `:theme` assigns in `<.profile_icon>`
…` schema - added `differentiation_rubric_id` field to `assessment_point_entries` table - added `scale_id` and `scale_type` fields to `assessment_point_entries`, and implemented composite foreign keys in the table to grant consistency between assessment points, entries, scales, and ordinal values (which demanded a significant refactor in everything related to assessment point entries) - chore: added a basic implementation of differentiation rubrics descriptors display
- created `LantternWeb.AssessmentPointLive.DifferentiationRubricComponent` to isolate each entry differentiation rubric tab panel, transfering part of the code from `LantternWeb.AssessmentPointLive.RubricsOverlayComponent` (and reducing the overal complexity) - added tab "management" in `<.person_tab>` component
- adjusted rubric/assessment point linking UX - Autocomplete hook adjustments, allowing implementation in curriculum and rubrics search - created `Rubrics.search_rubrics/2` and `LantternWeb.RubricsLive.RubricSearchInputComponent` - added `:assessment_points_rubric_id_fkey` fk constraint to `AssessmentPoint` schema preventing raise in case of rubric/assessment point scale mismatch - removed `RubricsOverlayComponent`'s `:new_rubric_linked` action notification - added `RubricsLive.RubricSearchInputComponent` to `RubricsOverlayComponent` - added rubric criteria gin index migration
- removed `maybe_filter_by_differentiation_flag/2` and `maybe_filter_by_scale/2` helper functions in favor of unified `apply_filters/2` - removed `:is_differentiation` attr from `RubricSearchInputComponent` in favor of `:search_opts`
…complete field - same as 60b0f38 but in entry level, for differentiation rubrics - adjusted Autocomplete hook js listeners to support multiple input field in same view - adjusted `RubricsLive.FormComponent` id to support multiple forms in same view
- added max width and truncate to `<.person_tab>` component - added flex wrap to entries/students tabs in assessment point details rubric overlay
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.