Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint error #470

Merged
merged 2 commits into from
Jan 7, 2021
Merged

Lint error #470

merged 2 commits into from
Jan 7, 2021

Conversation

sohamsshah
Copy link
Contributor

Description

The issue #469 is solved here. It relates to solving linting error in the code.

Motivation and Context

**Why is this change required? What problem does it solve?

How Has This Been Tested?

**Please describe in detail how you tested your changes.

Types of changes

**What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

**Go over all the following points, and put an x in all the boxes that apply.
**(If you're unsure about any of these, don't hesitate to ask. We're here to help!)

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@birm birm changed the base branch from master to develop January 7, 2021 19:03
Copy link
Member

@birm birm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A great first contribution, thank you! I wonder if there are any other oddities with windows.

@birm birm merged commit d8d7d57 into camicroscope:develop Jan 7, 2021
@birm birm mentioned this pull request Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants