Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coordinate System Fix #455

Merged
merged 3 commits into from
Nov 20, 2020
Merged

Coordinate System Fix #455

merged 3 commits into from
Nov 20, 2020

Conversation

Brayan-Valenzuela
Copy link
Contributor

Fix error using a model over the selected region #453

Changes made on the segment.js and model.js files to properly read the coordinates of the segmentations.
#453

Test the code by loading different segmentation and classification models into the system, comparing the result with the one shown in the demo on the caMicroscope page.

Types of changes

**What types of changes does your code introduce? Put an x in all the boxes that apply:

  • [ X ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

**Go over all the following points, and put an x in all the boxes that apply.
**(If you're unsure about any of these, don't hesitate to ask. We're here to help!)

  • [ X ] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Fix error using a model over the selected region camicroscope#453
Error using a model over the selected region camicroscope#453
@birm birm changed the base branch from master to develop November 20, 2020 15:14
@birm birm changed the title Patch 1 Coordinate System Fix Nov 20, 2020
Copy link
Member

@birm birm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@birm birm merged commit 3b598fd into camicroscope:develop Nov 20, 2020
This was referenced Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants