Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added download button in slide viewer [Enhancement] #392

Merged
merged 1 commit into from
May 15, 2020

Conversation

cjchirag7
Copy link
Contributor

@cjchirag7 cjchirag7 commented Apr 30, 2020

Description

Following changes have been made:

  • Added download tool inside the slide viewer.
  • Added download icon to README.md
  • Added download icon to the bootstrap tour guide.

Motivation and Context

  • This was marked as a 'to-do' in the uicallbacks.js file.

How Has This Been Tested?

  • Tested in Google Chrome and Firefox

Screenshots (if appropriate):

Screenshot from 2020-04-30 14-48-08

Types of changes

**What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

**Go over all the following points, and put an x in all the boxes that apply.
**(If you're unsure about any of these, don't hesitate to ask. We're here to help!)

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@birm birm self-requested a review May 1, 2020 04:04
Copy link
Member

@birm birm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable for what it is, I'm just unsure if this is desired. That todo message has an interesting history, and goes back in some form for two years, I think to the UI prototype for the 3.0 redesign. (it was just an alert in 32bd2cd)
I'll approve since it's a good PR, but not merge yet since I don't know if we still want it. Pinging @nanli-emory to give that clarification :)

@birm birm merged commit d671c61 into camicroscope:develop May 15, 2020
@birm birm mentioned this pull request May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants