-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Batch Loader Enhancement #389
Conversation
@birm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this!
This is good, with the addition of informing users of errors. If it put in a bad filename, it just silently fails, for example.
Thanks for the review. |
Of course, since this is an early app, there are still some things to hammer out. Up to you how much/little goes into each PR. (For example, the batch slide name field could be smart enough to borrow the file extension from the original filenames) |
Umm, what if the multiple files have different extensions? What do you think? @birm |
I think it's reasonable to have it use the source's file extension, though if someone goes in to manually change it, that's on them :) |
The following changes have been made:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks the work and changes!
Description
Some features are added to the batch loader:
Info
icon is added which to every row which on click describes various information about the slide likeoriginal filename
,filename
,slide name
,status
,token
etc.Motivation and Context
How Has This Been Tested?
Tested on:
Screenshots:
Types of changes
Checklist: