-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Information Dashboard button moved to slides page #376
Information Dashboard button moved to slides page #376
Conversation
A small change but I thought it might make more sense like this. Any thoughts? |
@akhil-rana , well I think keeping the option in navbar is better as users can easily see the option from any page. These are my thoughts anyways. |
I'll let resident ui magician @nanli-emory share their thoughts! |
@birm @akhil-rana This is my personal opinion. We can discuss it back and forward. Thanks. 😄 |
That's a good point. It's almost like an extended version of the review check tool you had made before. At the least then, we could add viewer links to the info page. |
@nanli-emory We may need to scale the dashboard later on. |
Or maybe we could use bootstrap tabs inside the slides page where the |
What about this? @nanli-emory |
@akhil-rana , this looks fine on the desktop (except the upload and reload icons, which should be fixed). But in small screens, the tabs are colliding with the other options - I think this is due to not closing the |
Okay, thanks for pointing it out. I'll fix that. |
@akhil-rana Yes, this is exactly what I was talking about. Nice |
@nanli-emory |
Looks good to me ! |
I was thinking of adding the tooltip already to many other elements like other buttons(delete, edit etc..) and navigations too. |
Description
Information dashboard button has been removed from the nav-bar and a butoon is added into the slides page itself.
Motivation and Context
**Why is this change required? What problem does it solve?
It makes more sense to have the dashboard build into the slides page rather than having a different switch in the nav-bar.
How Has This Been Tested?
This does not affect any other areas of code,
Screenshots:
Types of changes
Checklist: