Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Information Dashboard button moved to slides page #376

Merged
merged 9 commits into from
Jun 17, 2020

Conversation

akhil-rana
Copy link
Contributor

Description

Information dashboard button has been removed from the nav-bar and a butoon is added into the slides page itself.

Motivation and Context

**Why is this change required? What problem does it solve?
It makes more sense to have the dashboard build into the slides page rather than having a different switch in the nav-bar.

How Has This Been Tested?

  • Tested on Mozilla 75.0, Chrome 81.0
  • Ubuntu 19.10

This does not affect any other areas of code,

Screenshots:

ezgif-7-31211b86a29a

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@akhil-rana
Copy link
Contributor Author

A small change but I thought it might make more sense like this. Any thoughts?

@cjchirag7
Copy link
Contributor

@akhil-rana , well I think keeping the option in navbar is better as users can easily see the option from any page. These are my thoughts anyways.

@birm
Copy link
Member

birm commented Apr 17, 2020

I'll let resident ui magician @nanli-emory share their thoughts!

@nanli-emory
Copy link
Member

@birm @akhil-rana
Option 1 (I don't know the detail of your perspective for the dashboard. You can easily add two fields into slides page's table if you only want to show # annotation and # heatmap.): you can move annotation and heatmap fields into the slides page.
Option 2 (good for scaling dashboard content): Form user habits, you should use tabs to split two contents. The benefit is that users will easily see and understand it.

This is my personal opinion. We can discuss it back and forward. Thanks. 😄

@birm
Copy link
Member

birm commented Apr 17, 2020

That's a good point. It's almost like an extended version of the review check tool you had made before. At the least then, we could add viewer links to the info page.

@akhil-rana
Copy link
Contributor Author

akhil-rana commented Apr 17, 2020

@nanli-emory
I was going for something like your option 2 only.
Do you think a bootstrap button group might work or something like that?
Or nav-bar option should stay?

We may need to scale the dashboard later on.
And since dashboard is the part of slides only (at least for now) then it might be nicer to put that into slides page?

@akhil-rana
Copy link
Contributor Author

Or maybe we could use bootstrap tabs inside the slides page where the info button is placed in the above screenshot?

@akhil-rana
Copy link
Contributor Author

What about this? @nanli-emory

ezgif-3-31d9843dd661

@cjchirag7
Copy link
Contributor

cjchirag7 commented Apr 17, 2020

@akhil-rana , this looks fine on the desktop (except the upload and reload icons, which should be fixed). But in small screens, the tabs are colliding with the other options -
tabs-1

tabs-2

I think this is due to not closing the <div> containing these tabs. You may wish to fix this.

@akhil-rana
Copy link
Contributor Author

Okay, thanks for pointing it out. I'll fix that.

@nanli-emory
Copy link
Member

@akhil-rana Yes, this is exactly what I was talking about. Nice tabs. Thanks. @cjchirag7 caught the mobile-friendly bugs. 😄

@akhil-rana
Copy link
Contributor Author

akhil-rana commented Apr 17, 2020

@nanli-emory
@cjchirag7
This position would work? Sorry for the changes again and again.

ezgif-6-c4c261dba44c

@cjchirag7
Copy link
Contributor

Looks good to me !
You may wish to add a tooltip, so that it helps users to find the information dashboard easily, if it looks better.

@akhil-rana
Copy link
Contributor Author

I was thinking of adding the tooltip already to many other elements like other buttons(delete, edit etc..) and navigations too.

@birm birm requested a review from nanli-emory April 17, 2020 17:11
@birm birm merged commit 0ab833a into camicroscope:develop Jun 17, 2020
@akhil-rana akhil-rana deleted the info_dashboard_in_slidesPage branch June 17, 2020 23:03
@birm birm mentioned this pull request Jun 24, 2020
@akhil-rana akhil-rana mentioned this pull request Aug 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants