Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made search working and placed search icon [Fixes #355] #356

Merged
merged 1 commit into from
Apr 12, 2020

Conversation

cjchirag7
Copy link
Contributor

Closes #355

I have made the following changes

  • Improved the implementation of search, so that it works perfectly and pagination is also taken care
  • Changed the search placeholder, to include a search icon

A screencast of the working -
new-search

@birm birm self-requested a review April 12, 2020 06:00
Copy link
Member

@birm birm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the search and pagination don't work when stacktables is active (very narrow/mobile sized screen). I think it's ok to resolve this by either fixing the search for this case, or by not displaying the searchbar on small screens.

@cjchirag7
Copy link
Contributor Author

cjchirag7 commented Apr 12, 2020

@birm , it is not even working on my desktop. I have tested it for both Chrome and Firefox in my desktop, as described in the issue #355

@birm
Copy link
Member

birm commented Apr 12, 2020

Ok, we can merge this as a bugfix for that case. Thanks for the work!

@birm birm merged commit d0c2d20 into camicroscope:develop Apr 12, 2020
@cjchirag7 cjchirag7 deleted the fix_search branch April 12, 2020 06:13
This was referenced Apr 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants