Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selection issue fix #260

Merged
merged 9 commits into from
Mar 29, 2020
Merged

selection issue fix #260

merged 9 commits into from
Mar 29, 2020

Conversation

leoarc
Copy link
Contributor

@leoarc leoarc commented Mar 27, 2020

If the region selected for prediction is smaller than the input size requirement of the model , the page got stuck at :

Selection_027

And there's a corresponding memory leak :

Selection_026

Fixed this and added an alert to tell user to select a larger section . But I cannot understand why self.close( ) is not working for closing the modelpanel

Please review @Insiyaa @birm

@Insiyaa
Copy link
Contributor

Insiyaa commented Mar 28, 2020

Thanks for fixing this redundant computation!
self.close() is working, due to this line it remains open. A temporary fix maybe to put some timeout before self.close() :p.
@birm might have some better suggestions.

@birm
Copy link
Member

birm commented Mar 28, 2020

ModelPanel.prototype.open is an async function, so it returns a promise, so you could use .then to call something after it's finished.

@leoarc
Copy link
Contributor Author

leoarc commented Mar 28, 2020

@birm @Insiyaa I know this is not a clean way but does this look good to you ? ( Also sorry for so many commits , I messed up trying to resolve conflicts)

@birm
Copy link
Member

birm commented Mar 28, 2020

We'll squash on merge :)

@birm birm merged commit 910ea1f into camicroscope:develop Mar 29, 2020
@birm birm mentioned this pull request Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants