Skip to content

Commit

Permalink
Bug in column_format using test column (wintersrd#59)
Browse files Browse the repository at this point in the history
* Bug in column_format using test column

* Bumping versions, adding change log.
  • Loading branch information
s7clarke10 authored Nov 2, 2023
1 parent f5bc24a commit b21261d
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# tap-mssql 2.2.1 2023-10-30

* Bug Fix. Removing test code which slipped into the release, and adjusting offending code with correct dynamic column name.

# tap-mssql 2.2.0 2023-08-23

This feature increases support for SQL Datatypes.
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "tap-mssql"
version = "2.2.0"
version = "2.2.1"
description = "A pipelinewise compatible tap for connecting Microsoft SQL Server"
authors = ["Rob Winters <[email protected]>"]
license = "GNU Affero"
Expand Down
2 changes: 1 addition & 1 deletion tap_mssql/sync_strategies/common.py
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ def prepare_columns_sql(catalog_entry, c):
"""
elif sql_data_type == 'datetimeoffset':
return f"""case when {column_name} is not null then
CONVERT(VARCHAR,dt_offset_col,127)
CONVERT(VARCHAR,{column_name},127)
else null end
"""

Expand Down

0 comments on commit b21261d

Please sign in to comment.