Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deleting parameterized replaceable event before event #354

Conversation

cameri
Copy link
Owner

@cameri cameri commented Jan 12, 2024

Description

Fixes an error when an delete event is received before the parameterized replaceable event and the parameterized replaceable event causes an error.

Related Issue

#343

Motivation and Context

How Has This Been Tested?

  1. Unit tests
  2. Integration tests

Screenshots (if appropriate):

Types of changes

  • Non-functional change (docs, style, minor refactor)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my code changes.
  • All new and existing tests passed.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 7498456949

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 55.037%

Totals Coverage Status
Change from base Build 7497622093: -0.2%
Covered Lines: 1289
Relevant Lines: 2304

💛 - Coveralls

Copy link

sonarcloud bot commented Jan 12, 2024

@cameri cameri merged commit 030bbb3 into main Jan 12, 2024
12 checks passed
@cameri cameri deleted the 343-bug-throws-error-when-receiving-a-replaceable-event-after-its-delete-event branch January 12, 2024 05:54
github-actions bot pushed a commit that referenced this pull request Jan 12, 2024
# [1.26.0](v1.25.2...v1.26.0) (2024-01-12)

### Bug Fixes

* `invoice.verifyURL` undefined from lnurl processor getInvoice ([#325](#325)) ([33c2fd5](33c2fd5))
* deleting parameterized replaceable event before event ([#354](#354)) ([030bbb3](030bbb3))
* strange behavior with nip 33 parameterized replacable events and nip 40 expiration tag ([#316](#316)) ([d1d4cb9](d1d4cb9))
* typos ([#334](#334)) ([3b5b1fc](3b5b1fc))

### Features

* add nodeinfo support ([#347](#347)) ([d9e4020](d9e4020))
* **event_tags:** Add event_tags table and migration script ([#349](#349)) ([9bf0262](9bf0262))
Copy link

🎉 This PR is included in version 1.26.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants