Adds Create Camel projecy to the welcome screen #1994
Draft
+223
−124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removes "enablement" for the project creation commands because we will be always choosing a folder work with. - Project creation commands do not depend on the workspace root anymore and can be used without one. - Refactor existing tests to use the additional folder selection dialog. - Adds a modal to confirm the project creation since the 'camel export' command can clean the selected output folder. - Opens a new VSCode instance in the newly created project's folder. Signed-off-by: Marcelo Henrique Diniz de Araujo <[email protected]>
- Rename NewCamelProjectCommand class to reflect its abstract nature. - Create a 'generic' NewCamelProjectCommand that asks the user to select a runtime. Register the command with 'enablement = false' so that its does not show in the command palette. - Refactor other classes with the new project structure. Signed-off-by: Marcelo Henrique Diniz de Araujo <[email protected]>
|
djelinek
reviewed
Oct 31, 2024
| "title": "Create a Camel project", | ||
| "category": "Camel", | ||
| "enablement": "false" | ||
|
|
|
|
||
| public static readonly ID_COMMAND_CAMEL_QUARKUS_PROJECT = 'camel.jbang.project.quarkus.new'; | ||
|
|
||
| getRuntime(): string { | ||
| async getRuntime(): Promise<string> { |
There was a problem hiding this comment.
is this really needs to be an async function?
|
|
||
| public static readonly ID_COMMAND_CAMEL_SPRINGBOOT_PROJECT = 'camel.jbang.project.springboot.new'; | ||
|
|
||
| getRuntime(): string { | ||
| async getRuntime(): Promise<string> { |
There was a problem hiding this comment.
is this really needs to be an async function?
| @@ -37,7 +38,7 @@ import { | |||
| } from '../utils/testUtils'; | |||
| import * as pjson from '../../../package.json'; | |||
|
|
|||
| describe('Create a Camel Project using command', function () { | |||
| describe.only('Create a Camel Project using command', function () { | |||
There was a problem hiding this comment.
remove only when code is ready
| @@ -1,6 +1,7 @@ | |||
| # Change Log | |||
|
|
|||
| ## 1.6.0 | |||
| - Provide folder selection when using `Create Camel Quarkus/SpringBoot Project` command | |||
|
|
|||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Create Camel projecy to the welcome screen