FUSETOOLS2-2113 - Allows selection of folder when creating projects #1952
Conversation
hdamarcelo
commented
Oct 5, 2024
•
hdamarcelo
commented
- Removes "enablement" for the project creation commands because we will be always choosing a folder work with.
- Project creation commands do not depend on the workspace root anymore and can be used without one.
- Refactor existing tests to use the additional folder selection dialog.
- Opens a new VSCode instance in the newly created project's folder.
|
|
hdamarcelo
force-pushed
the
FUSETOOLS2-2113
branch
3 times, most recently
from
7f7f637
to
6b37f60
Compare
| @@ -37,7 +37,7 @@ import { | |||
| } from '../utils/testUtils'; | |||
| import * as pjson from '../../../package.json'; | |||
|
|
|||
| describe('Create a Camel Project using command', function () { | |||
| describe.only('Create a Camel Project using command', function () { | |||
There was a problem hiding this comment.
comment to not forget to remove the .only when PR is ready
| 'export', | ||
| `--runtime=${runtime}`, | ||
| `--gav=${gav}`, | ||
| `'--directory=${outputPath}'`]); |
There was a problem hiding this comment.
to double-check the behavior when there is something in the target folder and/or when using the current folder with various version of JBang because there were some issues in the past using this parameter fr another jbang command https://issues.apache.org/jira/browse/CAMEL-21082
There was a problem hiding this comment.
Tested more locally and issue you mentioned is only solved for the init subcomand. In this JBang task we are using camel export which cleans the contents of the folder especified in the --directory= option.
hdamarcelo
force-pushed
the
FUSETOOLS2-2113
branch
3 times, most recently
from
ba4ee49
to
8c858e6
Compare
hdamarcelo
force-pushed
the
FUSETOOLS2-2113
branch
from
8c858e6
to
9a280cb
Compare
| while (await input.isDisplayed()) { | ||
| await input.confirm(); | ||
| } |
There was a problem hiding this comment.
Why confirming potentially several times?
| await driver.wait(async function () { | ||
| input = await InputBox.create(); | ||
| return input; | ||
| }, 30000); |
There was a problem hiding this comment.
What about using
input = await InputBox.create(30000);
|
could you also please share the gif with Modal asking for |
|
- Removes "enablement" for the project creation commands because we will be always choosing a folder work with. - Project creation commands do not depend on the workspace root anymore and can be used without one. - Refactor existing tests to use the additional folder selection dialog. - Adds a modal to confirm the project creation since the 'camel export' command can clean the selected output folder. - Opens a new VSCode instance in the newly created project's folder. Signed-off-by: Marcelo Henrique Diniz de Araujo <[email protected]>
hdamarcelo
force-pushed
the
FUSETOOLS2-2113
branch
from
9a280cb
to
39d332c
Compare
|
