Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential NPE #296 #302

Merged
merged 1 commit into from
Oct 2, 2019
Merged

Conversation

apupier
Copy link
Member

@apupier apupier commented Sep 25, 2019

Signed-off-by: Aurélien Pupier [email protected]

Pull Request informations

Rebase & Merge default requirements

  1. Green build for master branch
  2. Wait 24 hours after PR creation
  3. Green job for PR
  4. Approved PR

PR labels default process

  • READY_FOR_REVIEW → REVIEW_DONE → READY_FOR_MERGE

Tests

  • Are there Unit tests?
  • Are there Integration tests?
  • Do we need a new UI test?

PR workflow progress

  1. Tagged with relevant PR labels
  2. Green job for PR
  3. PR was created more than 24 hours ago or All committers approved it
  4. Green master branch build

- reported by Sonar
- created test for this piece of code and discovered that the case of
backslash is not handled. Created camel-tooling#301 to handle it

Signed-off-by: Aurélien Pupier <[email protected]>
@apupier apupier merged commit 39ad273 into camel-tooling:master Oct 2, 2019
@apupier apupier deleted the 296-fixPotentialNPE branch October 2, 2019 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants