Fixed Design and implementation code smells #966
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
essobedo
reviewed
Nov 21, 2023
| @@ -300,6 +300,7 @@ public String getErrorMessage(EndpointValidationResult result, Map.Entry<String, | |||
| } | |||
| } | |||
|
|
|||
|
|
|||
essobedo
reviewed
Nov 21, 2023
| return (element instanceof PsiLiteralExpression || element instanceof PropertyValueImpl) && parentOfType == null; | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
One empty line is good enough
essobedo
reviewed
Nov 21, 2023
|
|
||
| return getAttributeReferences(attribute, value, context); | ||
| } | ||
| //IMPLEMENTATION SMELL OF IF STATEMENT |
There was a problem hiding this comment.
Not sure what you mean by this, please clarify or remove it
essobedo
reviewed
Nov 21, 2023
...-plugin/src/main/java/com/github/cameltooling/idea/runner/debugger/CamelDebuggerPatcher.java
Show resolved
Hide resolved
essobedo
reviewed
Nov 21, 2023
| } else { | ||
| writer = GradleFileWriter.GROOVY; | ||
| } | ||
| writer = targetBuildFileName.endsWith(".kts") ? GradleFileWriter.KOTLIN : GradleFileWriter.GROOVY; |
There was a problem hiding this comment.
ditto, please revert since it doesn't help much
essobedo
reviewed
Nov 21, 2023
...in/src/main/java/com/github/cameltooling/idea/runner/debugger/CamelForkedDebuggerThread.java
Outdated
Show resolved
Hide resolved
essobedo
reviewed
Nov 21, 2023
| @@ -87,31 +87,13 @@ public String getBeanName(PsiClass clazz) { | |||
| * @param project - Project reference to narrow the search inside. | |||
| * @return the {@link PsiClass} matching the bean name and annotation. | |||
| */ | |||
|
|
|||
There was a problem hiding this comment.
useless empty line, please revert
essobedo
reviewed
Nov 21, 2023
| returnName = StringUtils.stripDoubleQuotes(componentAnnotation.getText()); | ||
| } else { | ||
| returnName = Introspector.decapitalize(clazz.getName()); | ||
| } |
There was a problem hiding this comment.
ditto, it doesn't bring much so please revert
|
closing stale PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted Methods:
Extracted the method getBeanName to improve readability and isolate the logic for obtaining bean names based on annotations. The method now uses more descriptive names and has a single responsibility.
Extracted the method getBeanNameForAnnotation to encapsulate the logic of retrieving bean names from annotations, promoting code reuse.
Renamed Methods and Variables:
Renamed the method getBeanName to getBeanNameForAnnotations to better reflect its purpose.
Renamed the variable str to choicesString in the getErrorMessage method for clarity.
Decomposed Conditional Statements:
Decomposed the conditional statements in the getBeanNameForAnnotations method to simplify the logic and make it more straightforward.
Simplified the conditional statement in the getErrorMessage method by introducing a boolean variable hasSuggestions.
Introduced Explaining Variables:
Introduced the variable choicesString in the getBeanNameForAnnotations and getErrorMessage methods to explain the purpose of the string representation of choices.
Removed Unused Code:
Removed unused imports and variables, ensuring a cleaner codebase.
Optimized Enumerations:
Leveraged Java 8 features to handle enumerations more concisely, improving code efficiency.