Add "ATH" to "OAK" cleaning

camdenk · Nov 14, 2024 · ffa8209 · ffa8209
1 parent 08c88de
commit ffa8209
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 1 deletion.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,7 +1,7 @@
 Package: mlbplotR
 Type: Package
 Title: Create 'ggplot2' and 'gt' Visuals with Major League Baseball Logos
-Version: 1.1.0.9006
+Version: 1.1.0.9007
 Authors@R: 
     c(
     person(given = "Sebastian",

diff --git a/NEWS.md b/NEWS.md
@@ -6,6 +6,7 @@
 * Update `gt_*` functions to be used in gt row group labels and accept unquoted column names, add `gt_fmt_milb_logo()` (v1.1.0.9004)
 * Add `gt_` and `geom_` functions for MiLB dot team logos and headshots (v1.1.0.9005)
 * Documentation updates (v1.1.0.9006)
+* Added "ATH" -> "OAK" in `clean_team_abbrs()` (v1.1.0.9006)
 
 # mlbplotR 1.1.0
 

diff --git a/R/sysdata.rda b/R/sysdata.rda
diff --git a/data-raw/build_internal_data.R b/data-raw/build_internal_data.R
@@ -15,6 +15,8 @@ scoreboard_logo_list <- old_logo_lists[[2]]
 #
 # logo_list <- rlang::set_names(logo_list, teams_colors_logos$team_abbr)
 
+# Only update Arizona because of their logo change. Otherwise, keep the old
+# ESPN logos
 az_url <- teams_colors_logos$team_logo_espn[teams_colors_logos$team_abbr == "AZ"]
 logo_list$AZ <- curl::curl_fetch_memory(az_url)$content
 
@@ -104,6 +106,7 @@ team_data <- tibble::tribble(~team, ~alternate,
                            "NYM", "NY",
                            "NYY", "NYY",
                            "OAK", "OAK",
+                           "OAK", "ATH",
                            "PHI", "PHI",
                            "PIT", "PIT",
                            "SD" , "SD",