Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Update Glossary.md #120

Merged
merged 14 commits into from
Mar 30, 2023
Merged

Update Glossary.md #120

merged 14 commits into from
Mar 30, 2023

Conversation

shilpa-padgaonkar
Copy link
Contributor

@shilpa-padgaonkar shilpa-padgaonkar commented Jan 16, 2023

This change extends the glossary document so that it not only explains the meaning of the terms already used in the APIs/documentations but also suggests developer friendly alternatives for existing identifiers which if agreed within our Camara project, can be replaced from current APIs and documentation

Fixes #108

This change extends the glossary document so that it not only explains the meaning of the terms already used in the APIs/documentations but also suggests developer friendly alternatives for existing identifiers which if agreed within our Camara project can be replaced from current APIs and documentation
Copy link
Contributor

@FabrizioMoggio FabrizioMoggio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A closed bracket is needed in the third column "Usage(API/Documentation)".

Anyway I'm wondering about that column.
I suggest to discriminate on "Parameters" and "Terms". I mean we can have a text like this in the documentation: "The UeId parameter represents the User Equipment". In the Glossary I think it is important to first work on the Term (User Equipment) and then we can also suggest to adopt a common Paramenter name.

So:

Current:
Term: User Equipment
Paramenter: UeId
Suggested:
Term: Device
Parameter: DevId

"Term" is used to describe the "Paramenter", in the YAML and in the Documentation.

@shilpa-padgaonkar
Copy link
Contributor Author

@FabrizioMoggio : The Intention is to not create too many documents that we would have to refer to in the end. Hence, a consolidated Glossary. I have changed the format of the doc slightly, which I hope would address your concerns.

@FabrizioMoggio
Copy link
Contributor

@shilpa-padgaonkar: thank you, the modified table addresses my comment. Just one more comment, in my understanding the last column is to propose a possible alternative for the Parameter/Field. So, maybe, it should be:

"Alternative developer-friendly Parameter/Filed"

@shilpa-padgaonkar shilpa-padgaonkar added the good first issue Good for newcomers label Jan 17, 2023
@eric-murray
Copy link
Contributor

I agree a glossary would be useful, but I think the initial definitions need a bit more thought. In particular, whilst I can't really argue with "Device Identifier" being "Identifier for a device", this doesn't really capture how APIs are using this identifier.

In most cases, the identifier is actually being used to identify the mobile subscription. For most APIs, if the SIM was moved to a different UE, the behaviour of the API would be unchanged, because it is the mobile subscription that is relevant. That is why it is called the "Anonymised Subscriber Identifier" API, and not the "Anonymised Device Identifier" API. Moving your SIM to a different UE doesn't change the identity you get back.

But there is a Device Identifier API, which returns IMEI. So changing UE changes the response of the API. In that case, the device identifier is not a "UEId", but is still a "Device Identifier".

I think the trick is to come up with definitions for the glossary that allow developers who do not fully understand the distinction between a "mobile device" and a "mobile subscription" to understand that distinction where it affects how the API is used.

@shilpa-padgaonkar
Copy link
Contributor Author

@eric-murray Those are just sample entries as stated in the note at the end of the document. Issues have been created under every subproject to add the real/actual entries they need with a description that accurately reflects the usage of the specified identifier. Feel free to update the entries as deemed fit.

I agree with your point that we would need to put more thought into some of the tricky terms/fields.
But IMHO, it will be difficult to start with perfect terms and descriptions. They will be refined over the course of time as we start adding to the Glossary and it will be a living document for the project which matures over time.

@jordonezlucena
Copy link
Contributor

@shilpa-padgaonkar: thanks for creating this PR. I agree we need to populate (and enhance) the table over course, as we get inputs from the Sub-Project leaders.
Two suggestions on the proposed table:

  • Add a new column called "In-scope APIs", just after or before "Usage in API (Parameter/Field)" column. This new column aims to list the CAMARA APIs that make use of this term.
  • Re-name "description" column to "definition". When providing the term definition, encourage contributor to include reference to relevant standard/industry fora (e.g., GSMA, ITU, 3GPP, IETF) where this term was originally defined.

@shilpa-padgaonkar
Copy link
Contributor Author

@jordonezlucena : I can update description to definition.
For your first point, I can add the column, but I do wonder if all APIs will update this glossary regularly and keep it up to date or will it go stale over time! Also, we will then be expected to mention all the documentations where a term has been used (thereby making the list too long)?

@jordonezlucena
Copy link
Contributor

@jordonezlucena : I can update description to definition.
For your first point, I can add the column, but I do wonder if all APIs will update this glossary regularly and keep it up to date or will it go stale over time! Also, we will then be expected to mention all the documentations where a term has been used (thereby making the list too long)?

My point is that, e.g. for "UeId", note that the API family "x", "y" and "z" make use of them. I'd not expect too many APIs make use of the same parameter. Anyway, we can try it out, and if we realise that it's quite complicated to keep this information updated, we can simply remove this column.

@shilpa-padgaonkar
Copy link
Contributor Author

@PedroDiez and @eric-murray : Could you kindly update your contributions to use camelCase? I will then consolidate the contributions from other subprojects here myself.

@PedroDiez
Copy link
Contributor

done @shilpa-padgaonkar

shilpa-padgaonkar and others added 5 commits March 29, 2023 14:11
Changes in Network Access Identifier, IP, Port; added Event Type
Alternative terms changed to camelCase.
@shilpa-padgaonkar shilpa-padgaonkar merged commit 1f6e58c into main Mar 30, 2023
@shilpa-padgaonkar shilpa-padgaonkar deleted the shilpa-padgaonkar-patch-6 branch April 4, 2023 09:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid telco specific terminology in APIs
6 participants