Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PhoneNumber pattern - clarification on optional "+" prefix #85

Closed
trehman-gsma opened this issue Jan 16, 2024 · 3 comments · Fixed by #100
Closed

PhoneNumber pattern - clarification on optional "+" prefix #85

trehman-gsma opened this issue Jan 16, 2024 · 3 comments · Fixed by #100

Comments

@trehman-gsma
Copy link
Collaborator

I am seeking clarification on the phone number pattern in the current spec. This is the schema:

    PhoneNumber:
      type: string
      pattern: '^\+?[0-9]{5,15}$'
      example: '+346661113334'
      description: Subscriber number in E.164 format (starting with country code). Optionally prefixed with '+'.

Regarding the "+" prefix:

  • Is the expectation that Operators must support both a phone number containing a "+" and support a phone number without a "+" prefix?
  • Or is it the operator choice to support either combination?

To elaborate, please see this table that represents the options of supporting a prefix. Are all options valid?

Operator supports number with a "+" prefix Operator supports number without a "+" prefix
Option 1 Y Y
Option 2 Y N
Option 3 N Y
@RubenBG7
Copy link

RubenBG7 commented Jan 16, 2024

From TEF we apply E.164 ISO to all variables relative to phone numbers, making sure that of course the content of the variable belongs to a phone number and to validate that the phone number belongs to the OB that is receiving the request.

Then reading the other issues in SIM SWAP API and NUMBER VERIFY, this is not hte first time that this discussion is oppened.

camaraproject/Commonalities#87
camaraproject/NumberVerification#65 (comment)

@eric-murray
Copy link

@trehman-gsma
It is up to each API to decide which features are "mandatory" to support and which are "optional". This would normally be done by specifying appropriate cucumber tests.

In this case, it makes sense for all CAMARA APIs that accept phoneNumber as an input to adopt the same requirements. That is probably a topic for the Release Management WG to discuss. I also agree that the argument for keeping the '+` optional is weak. That is a discussion for Commonalities.

@hdamker
Copy link
Collaborator

hdamker commented Mar 26, 2024

See camaraproject/Commonalities#148 ... ready to be merged - and will make the '+' mandatory, no longer optional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants