-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mandate '+' in all Phone Number formats #87
Comments
Hi @chrishowell, |
HI @chrishowell |
In fact in Glossary.md we have Phone Number described as: What should be changed or added to Design Guidelines to make it normative for CAMARA APIs? |
@rartych Asked the question to ...ChatGPT :) if "+"is mandatory in E.164: While the use of the "+" sign is strongly recommended and widely accepted in E.164 format, it is not technically mandatory. E.164 itself does not explicitly require the use of the "+" sign. However, in practice, the use of the "+" sign has become a convention to indicate the international dialing prefix. So probably we can add a note in Glossary that we mandate the '+' ? WDYT ? |
I suggest that we must apply the same definitions and rules from the Glossary across all APIs. For instance, in the case of device status, we have used the exact description "A public identifier addressing a telephone subscription. In mobile networks it corresponds to the MSISDN (Mobile Station International Subscriber Directory Number). In order to be globally unique it has to be formatted in international format, according to E.164 standard, optionally prefixed with '+'." , However, mentioning the "+" explicitly at the end of the statement is not ideal. Instead, it should be integrated within the glossary definition itself for clarity and consistency. |
Generally speaking,being explicit with the definition is the best way to avoid misunderstandings and and deviations in implementations. I think we can update the Glossary and apply the definition to every API: A public identifier addressing a telephone subscription. In mobile networks it corresponds to the MSISDN (Mobile Station International Subscriber Directory Number). In order to be globally unique it has to be formatted in international format, according to E.164 standard, prefixed with '+'. |
Referring to Issue #93 : would it be possible to define According to OAS spec:
|
A lot of platforms, and databases follow E.164 Interoperability is important. "DNS Mapping of E.164 numbers Additional Links |
Can we make a decision on this issue. My proposal is to make the inclusion of "+" mandatory in all cases as a commonality. |
I think it's a good idea to let client use phone numbers with or without the '+' sign. This way, both local and international users can enter numbers the way they're comfortable with. I believe, Camara's API will mostly be used by local Opco, for example, a UK client may not prefer to check the device status of Spanish people, so using '+44' may not be useful to them. So I would prefer to make it optional. |
Already agreed is e164 that uses country code so "44" in UK would already be mandated. Question is on mandating a "+44" or to leave as is where operators will need to code to handle both +44 and 44 as either can be used. Mandating "+" makes implementation simpler as you only need to support one option. |
Thanks for clarifying it @MarkCornall. However, mandating the '+' sign, like '+44' for the UK, makes things easier for developer as you stated and I agreed too. However, making it optional like '44' , gives users more choices and can be more friendly for them. So I would little favour client over developer but I'm open to either option . Thanks again. |
PR should be prepared covering Glossary, CAMARA_common.yaml and possibly API Design Guidelines |
Problem description
The standards are a bit iffy around whether or not a '+' is required for phone numbers, we've agreed in SimSwap to have a '+' only, but I think it makes its sense to make it an agreed CAMARA standard across all APIs.
Possible evolution
camaraproject/NumberVerification#65
The text was updated successfully, but these errors were encountered: