Patch release r1.3 #383
Patch release r1.3 #383
Conversation
r1.2 replaced by r1.3 Updated meeting time (UTC based)
added r1.3 content
hdamker
added
documentation
hdamker
requested review from
eric-murray,
RandyLevensalor and
jlurien
as code owners
|
@RandyLevensalor @eric-murray @jlurien could you have a view on this PR ... I suppose that we are ready for the patch release, but would be great to double-check the CHANGELOG etc. |
There was a problem hiding this comment.
@hdamker Can you please update documentation/API_documentation/qos-profiles-API-Readiness-Checklist.md to include that we now have a user story?
Co-authored-by: Jose Luis Urien <[email protected]>
Co-authored-by: Jose Luis Urien <[email protected]>
Co-authored-by: Jose Luis Urien <[email protected]>
…tory Signed-off-by: Herbert Damker <[email protected]>
@RandyLevensalor Sure ... done in 2b223a8 |
@jlurien Thanks for the review, all suggestions committed. |
hdamker
requested review from
RandyLevensalor,
jlurien,
eric-murray and
a team
| @@ -14,7 +14,7 @@ info: | |||
| - Discovery of all QoS profiles offered by the network operator | |||
| - Retrieve the characteristics of a specific QoS profile by name | |||
|
|
|||
| How QoS profiles are mapped to connectivity characteristics are subject to agreements between the communication service provider and the API invoker. Within the CAMARA project, you can find a sample for such a mapping of QoS profiles. [CAMARA QoS Profiles Mapping Table (REFERENCE DRAFT)](https://github.com/camaraproject/QualityOnDemand/blob/main/documentation/API_documentation/QoSProfile_Mapping_Table.md) | |||
| How QoS profiles are mapped to connectivity characteristics are subject to agreements between the communication service provider and the API invoker. Within the CAMARA project, you can find a sample for such a mapping of QoS profiles. [CAMARA QoS Profiles Mapping Table (REFERENCE DRAFT)](https://github.com/camaraproject/QualityOnDemand/blob/r1.3/documentation/API_documentation/QoSProfile_Mapping_Table.md) | |||
There was a problem hiding this comment.
change: communication service provider --> API provider
possibly also change: API invoker --> API consumer
| @@ -14,7 +14,7 @@ info: | |||
| - Discovery of all QoS profiles offered by the network operator | |||
There was a problem hiding this comment.
change multiple occurrences of : network operator --> API provider
- this comment also applies to the other API yamls
- same comment applies to the qos-profiles-UserStory.md (CSP/network operator -> API provider)
There was a problem hiding this comment.
- The abbreviation QoS is introduced in the middel of the intro paragraph rather than at the first occurrence.
- the text uses QoS Profiles with capital P - would change to lower case.
- Would add a simple explanation of what is a QoS profile in the beginning e.g. a QoS profile is a set of traffic characteristics of a session identified by a name (label) that can be used in session requests to indicate the needs of the application for its traffic.
- this comment also applies to the other API yamls
There was a problem hiding this comment.
Line 138: the example is mixed up:
|
Hi Herbert, sorry for the delay. I reviewed and have some comments, but you may decide to apply them in the next release. OK to go from release management team |
Hi Tanja, thanks for the comments. I created a new issue to consider them within the next release, they are going beyond the scope of a release PR. |
What type of PR is this?
What this PR does / why we need it:
Update of README and changelog for patch release r1.3
Updating release numbers and API versions across all files
Replacing links to main branch with release specific links (closing the remaining issue from the patch release scope in #
Which issue(s) this PR fixes:
Fixes #381
Fixes #363
Special notes for reviewers:
Create temporarily created branch
r1.3from main to be able to test the links. That branch will need be deleted before the release tag can be created.Changelog input