Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guidance for multi-SIM scenarios #378

Merged
merged 15 commits into from
Dec 5, 2024

Conversation

eric-murray
Copy link
Collaborator

What type of PR is this?

  • documentation

What this PR does / why we need it:

Provides guidance on using the QoD APIs in multi-SIM scenarios

Which issue(s) this PR fixes:

Fixes #376

Special notes for reviewers:

This guidance will need to be updated when Commonalities Issue #302 is resolved

Changelog input

 release-note
 - Add guidance for multi-SIM scenarios

Additional documentation

None

Copy link
Collaborator

@jlurien jlurien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In line with the latest consensus in camaraproject/Commonalities#324, I have included some suggestions. They will apply to all the 3 APIs with minor adjustments.

@eric-murray
Copy link
Collaborator Author

@camaraproject/quality-on-demand_codeowners
Text updated taking into account all comments. Ready for final review.

Copy link
Collaborator

@jlurien jlurien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @eric-murray, LGTM

@eric-murray eric-murray merged commit b9b0359 into camaraproject:main Dec 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document current behavior for devices with multiple SIMs
4 participants