-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make + prefix mandatory for phoneNumber #301
Conversation
@jlurien looks good, but you need to make the linter happy :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This actually corrects three issues with the regex.
- Requires +
- Reduces the minimum length
- Decreases max length
Actually there is no change of these lengths, previously it was max 15 digits of [0-9] and now it is one digit [1-9] followed by max 14 digits [0-9]. The additional check is that the first digit after the + can't be 0 (as there is no country code starting with 0). |
@RandyLevensalor |
Yes, new pattern is copied from the artifact in Commonalities |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks
What type of PR is this?
What this PR does / why we need it:
Alignment with Commonalities about + prefix for international E.164 phoneNumbers
Which issue(s) this PR fixes:
Fixes #298