-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alignment with API design guidelines #97
Comments
jlurien
added a commit
to jlurien/QualityOnDemand
that referenced
this issue
Jan 25, 2023
As discussed in issue [camaraproject#97](camaraproject#97), we have to align current error model and examples to the guidelines: - Add new `status` property - Created new `Generic500` response and $ref all previous instances
Suppose this issue is done:
The final decision in Commonalities was camelCase for property names, which we will continue to use. Also the new terms are applied (with #129)
Done with #104 |
All done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Some weeks ago, a set of API design guidelines have been approved in commonalities.
Regarding terminolgy and style:
Errors must include:
status
, which can be identified in the response as a standard code from list of Hypertext Transfer Protocol (HTTP) response status codes.code
, which can be identified and traced for more details. It must be human readable; therefore, it must not be a numeric code. In turn, to achieve a better location of the error, you can reference the value or field that is causing it, and include it in the message.message
.Proposed actions
Most of changes apply to current property names, as they must be formattted in snake_case. This can be addressed together with issue #90 in a new PR, when new terms are agreed.
We have to adapt errors, adding
status
, and at a same time we could enhance current documentation and examples. This can be done in separate PR.The text was updated successfully, but these errors were encountered: