Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guidelines alignment errors and camel case #30

Conversation

monamok
Copy link
Collaborator

@monamok monamok commented Mar 22, 2023

This PR is to handle issue#31 in order to align the API definition with following changes in the guidelines:

  • Parameters should be named in lowerCamelCase. Issue, Discussion & PR.
  • Adjust the schema references in the errors responses and apply the agreed solution: Issue & PR.

I removed the restriction for error status as in commonalities there is no agreement about limiting the integer values.

Looking forward to getting your feedback.

bigludo7
bigludo7 previously approved these changes Mar 22, 2023
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good !!

Copy link
Collaborator

@DT-DawidWroblewski DT-DawidWroblewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@DT-DawidWroblewski DT-DawidWroblewski merged commit ae5c82b into camaraproject:main Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants