-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding puml #24
Merged
DT-DawidWroblewski
merged 3 commits into
camaraproject:main
from
DT-DawidWroblewski:main
Mar 9, 2023
Merged
adding puml #24
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
@startuml | ||
|
||
title "MC Verified MSISDN" | ||
|
||
actor "Mobile App\nCustomer" as user | ||
box "Customer's Device" | ||
participant "Developer's App" as mApp | ||
end box | ||
|
||
box "MC IDGW" | ||
participant "/authorize" as auth | ||
participant "/token" as token | ||
participant "/userinfo" as userInfo | ||
end box | ||
|
||
activate user | ||
user -> mApp: opens Developer's App | ||
activate mApp | ||
mApp -> auth: scope=openid mc_verified_msisdn\n&state={...}\n&{query params defined inside MC specs} | ||
activate auth | ||
auth -> auth: Verified\nMSISDN\nflow | ||
note right: MNO detects device MSISDN\nusing mobile data session details | ||
mApp <- auth: {code} (auth successful) | ||
deactivate auth | ||
mApp -> token: code={code} | ||
activate token | ||
mApp <- token: tokens {id_token, access_token} | ||
deactivate token | ||
mApp -> userInfo: access_token={access_token,msisdn} | ||
activate userInfo | ||
mApp <- userInfo: {"device_msisdn_verified": true} | ||
deactivate userInfo | ||
deactivate mApp | ||
user <- mApp: user inside app | ||
|
||
|
||
@enduml |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About the scopes I was told in other working groups that we have to wait till we get into an agreements for scopes in commonalities so we avoid inconsistancy in CAMARA project. What do you think about this point @DT-DawidWroblewski @bigludo7 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me when the scope has been already defined in the standard - Mobile Connect for example - we have to take it as such to avoid confusion for implementation knowing it. I guess this is the case here.