Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify description in yaml file #102

Merged
merged 2 commits into from
May 29, 2024
Merged

clarify description in yaml file #102

merged 2 commits into from
May 29, 2024

Conversation

AxelNennker
Copy link
Collaborator

@AxelNennker AxelNennker commented Apr 26, 2024

What type of PR is this?

Add one of the following kinds:

  • bug
  • correction

What this PR does / why we need it:

user and subscriber should not be confused.

Fixes #101

bigludo7
bigludo7 previously approved these changes May 15, 2024
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry - went to fast on this one.

@bigludo7 bigludo7 self-requested a review May 15, 2024 12:20
@AxelNennker AxelNennker changed the title WIP: clarify description in yaml file clarify description in yaml file May 29, 2024
@AxelNennker
Copy link
Collaborator Author

I resolved merge conflicts and removed the text in this PR's description on 3-legged tokens.
Please review

Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

Copy link
Collaborator

@fernandopradocabrillo fernandopradocabrillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AxelNennker AxelNennker merged commit b81946f into main May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rephrase description in yaml
4 participants