-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
operator token login_hint format #218
Conversation
In my opinion, using acronyms is not a good idea because it makes it harder to recognize the meaning of the prefix at a glance. Additionally, if we add new prefixes in the future, although unlikely, the initials could potentially collide. My proposal is to use |
ipport is also an acronym ... |
My view is that we should name scheme = ALPHA *( ALPHA / DIGIT / "+" / "-" / "." ) This would exclude underscores from valid names. Note that URI schemes are case-insensitive. So |
This document defines prefixes to be used in login_hint. If this document specifies If you insist, we can add text but I do not see a need. |
@garciasolero Are you OK with @sebdewet 's proposal to use |
Co-authored-by: Eric Murray <[email protected]>
Actually, it does:
RFC 3966 defines |
I think URI schemes introduce more problems than bring benefit. I would keep the prefixes as defined. @sebdewet please review. |
Yes, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok if we keep tel: ipport: and operatortoken:
What type of PR is this?
What this PR does / why we need it:
It was proposed to
login_hint
to convey operator token to the Camara Authorization Server.This way OIDF and IETF standards don't need to be extended.
Which issue(s) this PR fixes:
Fixes #145