Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace internal links between icm documents with relative links #188

Conversation

hdamker
Copy link
Collaborator

@hdamker hdamker commented Jul 31, 2024

What type of PR is this?

Add one of the following kinds:

  • correction

What this PR does / why we need it:

See #187

Which issue(s) this PR fixes:

Fixes #187

Special notes for reviewers:

Tested on GitHub within the PR source branch and with local renderer (Xcode).

Changelog input

 Replaced internal links between ICM documents with relative links

hdamker added 3 commits July 31, 2024 15:19
Replaced absolute links to Profile with relative links
Replaced ICM internal link with relative one
Links corrected, second attempt
Bringing unintentional changed table of contents back .
Copy link
Collaborator

@jpengar jpengar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few comments...

documentation/CAMARA-API-access-and-user-consent.md Outdated Show resolved Hide resolved
sebdewet
sebdewet previously approved these changes Jul 31, 2024
Copy link
Collaborator

@sebdewet sebdewet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

AxelNennker
AxelNennker previously approved these changes Jul 31, 2024
jpengar added a commit that referenced this pull request Jul 31, 2024
reverted the link within code block as already addressed within camaraproject#186
@hdamker hdamker dismissed stale reviews from AxelNennker and sebdewet via a4bcb0c July 31, 2024 14:57
Copy link
Collaborator

@jpengar jpengar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpengar jpengar merged commit cd094a0 into camaraproject:main Jul 31, 2024
@jpengar jpengar mentioned this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants