-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clarification related to issue 108 added to CAMARA-API-access-and-user-consent.md #120
Conversation
@Elisabeth-Ericsson I've added Axel and the active participants in issue #108. My main concern with the proposed text is that we should keep CAMARA technical documentation and API specs separate from Open Gateway product definitions and legal dependencies. So, for example, specifying the 1:1 relationship between Open Gateway product and APIs (which AFAIK is true so far), and things like that, should not be done in the CAMARA I&CM technical docs. These docs only provide the supported technical flows, the technical ruleset to be applied to support the different potential CAMARA use case scenarios and so on. I'm fine with including further clarifications as a result of issue #108 (if needed), but not specific Open Gateway definitions that should be agnostic to CAMARA, right? Let's see what others think. |
The text proposal uses many terms that are not in the CAMARA glossary. Please use terms already defined in the glossary where possible. If you need to use a term that is not defined, please provide a definition for that and introduce it into the glossary. Without clear definitions, these sorts of statements are open to misinterpretation. Also, I agree that CAMARA specifications should say nothing about "products" or attempt to give legal guidance. Leave that to Open Gateway. CAMARA should just focus on providing the technical mechanisms that allow API Providers to offer API products that are compliant with local regulation. |
Signed-off-by: Axel Nennker <[email protected]>
Signed-off-by: Axel Nennker <[email protected]>
@eric-murray: I agree to remove the note on current API to API product relationship. I will rephrase and include the reference to TMF 931. |
Signed-off-by: Axel Nennker <[email protected]>
Co-authored-by: Shilpa Padgaonkar <[email protected]>
Signed-off-by: Axel Nennker <[email protected]>
@Elisabeth-Ericsson |
Hello @Elisabeth-Ericsson Reference them make sense in Open Gateway for sure but not here. |
References to TMF Operate APIs removed, since these are only applicable to scenario with aggregators/channel partners |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
@Elisabeth-Ericsson FYI. I've edited the PR description only to correct the format of this part:
So, when this PR is merged, issue #108 will be automatically closed :) |
Co-authored-by: Jesús Peña García-Oliva <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I would like to merge this. We have some approvals and no further comments for a week. |
@AxelNennker: can you please merge this pull request ? All reviewers have approved. |
With @AxelNennker 's permission, I can do it. No problem. |
What type of PR is this?
What this PR does / why we need it:
urgent clarification needed on mechanism to decide for authorization flow to apply for API invocation
Which issue(s) this PR fixes:
Fixes #108
Special notes for reviewers:
A single paragraph describing the handling on authorization flow selection during API product order has been added at the end of the document.
@shilpa-padgaonkar: Can you please have a look at this ?