Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Email_Settings.md #165

Merged
merged 11 commits into from
Nov 22, 2024
Merged

Update Email_Settings.md #165

merged 11 commits into from
Nov 22, 2024

Conversation

eharrison24
Copy link
Contributor

What type of PR is this?

  • correction
  • enhancement
  • cleanup
  • documentation
  • project management

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Additional documentation

This section can be blank.

Copy link

linux-foundation-easycla bot commented Nov 8, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link
Collaborator

@hdamker hdamker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion to structure the document differently, showing only the differences in setup for the special lists main, adm, board, and tic-private. All other lists including [email protected] have the same settings.

documentation/Email_Settings.md Outdated Show resolved Hide resolved
documentation/Email_Settings.md Outdated Show resolved Hide resolved
documentation/Email_Settings.md Outdated Show resolved Hide resolved
documentation/Email_Settings.md Outdated Show resolved Hide resolved
documentation/Email_Settings.md Outdated Show resolved Hide resolved
documentation/Email_Settings.md Outdated Show resolved Hide resolved
documentation/Email_Settings.md Outdated Show resolved Hide resolved
Comment on lines 17 to 24

**AND**

All:
* Unrestricted Membership
* Messages are not moderated
* New Members Moderated: Unmoderated after one (1) approved message
* Message Policies: "Allow Parent Members to Post"
Copy link
Collaborator

@hdamker hdamker Nov 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**AND**
All:
* Unrestricted Membership
* Messages are not moderated
* New Members Moderated: Unmoderated after one (1) approved message
* Message Policies: "Allow Parent Members to Post"
For "all" mailing list:
* Group Type and Moderation:
* Message Moderation: All messages are moderated.

documentation/Email_Settings.md Outdated Show resolved Hide resolved
documentation/Email_Settings.md Outdated Show resolved Hide resolved
@eharrison24
Copy link
Contributor Author

Hi @MarkusKuemmerle and @wrathwolf I meant to initially include you as reviewers when I did this PR - please take some time to review if you haven't done so already.

@eric-murray @bigludo7 - Please disregard, and (please approve) this PR, you guys got added somehow and I do not know how to remove you from the reviewer list.

bigludo7
bigludo7 previously approved these changes Nov 21, 2024
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hdamker
Copy link
Collaborator

hdamker commented Nov 21, 2024

@eharrison24 @MarkusKuemmerle I took the freedom to commit my suggestions and doing a final clean-up. I'm quite confident that the documented setting are in line with our discussion and the actual settings within groups.io. Please review.

@bigludo7 there are several changes compared to the version you have reviewed, mostly the ones I had suggested in my review comments.

Copy link
Collaborator

@hdamker hdamker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm obviously fine with the changes I have done :-) (it's also a loophole that I can rewrite the PR and then approve it myself).

@hdamker
Copy link
Collaborator

hdamker commented Nov 22, 2024

@eharrison24 please have a look on the changes I did if you are ok with them.

@eharrison24
Copy link
Contributor Author

Hi @hdamker - From what I'm looking at now, the changes seem to make sense!

@eharrison24 eharrison24 merged commit e87ee2b into main Nov 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants