Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Traffic_Influence_API_Readiness_Checklist.md #224

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

FabrizioMoggio
Copy link
Collaborator

@FabrizioMoggio FabrizioMoggio commented Mar 21, 2024

the API implementation is not Mandatory

What type of PR is this?

  • correction
  • documentation

What this PR does / why we need it:

to be aligned with: https://github.com/camaraproject/Commonalities/blob/main/documentation/API-Readiness-Checklist.md

the API implementation is not Mandatory
@FabrizioMoggio FabrizioMoggio added documentation Indicating issues with API documentation or supplementary documents correction Suggesting corrections of API specification or indicating misalignment with API design guidelines labels Mar 21, 2024
Copy link

🦙 MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 2 0 0.02s
✅ JSON eslint-plugin-jsonc 1 0 0 1.31s
✅ JSON jsonlint 1 0 0.17s
✅ JSON prettier 1 1 0 0.91s
✅ JSON v8r 1 0 1.96s
❌ OPENAPI spectral 9 7 17.0s
✅ REPOSITORY git_diff yes no 0.55s
✅ REPOSITORY secretlint yes no 4.48s
❌ YAML yamllint 9 1 4.51s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@FabrizioMoggio
Copy link
Collaborator Author

I don't get why this PR is blocked. It seams to me that MegaLinter detects an error on other yaml files (e.g. MEC exposure and experience management.yaml).

@javierlozallu have you any suggestion? Is there any action I need to do?

@javierlozallu
Copy link
Collaborator

Yes, MegaLinter is controlling the yaml format and we need to adapt the line length to 80 characters. SED and LCM are already adapted, you can check it out. But we have some old YAMLs that need to be adapted if we have to keep them or delete them. But you can merge this PR now that I have approved.

@FabrizioMoggio FabrizioMoggio merged commit c420666 into main Apr 11, 2024
1 check failed
@gunjald
Copy link
Collaborator

gunjald commented Apr 11, 2024

We should have a way to tell mega linter what files are to be checked instead of whole repository. Or we move the files not required in some achieves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
correction Suggesting corrections of API specification or indicating misalignment with API design guidelines documentation Indicating issues with API documentation or supplementary documents
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants