Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting workflow added #216

Merged
merged 8 commits into from
Mar 21, 2024
Merged

Linting workflow added #216

merged 8 commits into from
Mar 21, 2024

Conversation

Kevsy
Copy link
Collaborator

@Kevsy Kevsy commented Feb 27, 2024

Commonalities release 0.3.0 defines the linting integration guidelines for automated testing via Github actions. This PR adds the files and configuration to achieve this.

Copy link

🦙 MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 2 0 0.03s
✅ JSON eslint-plugin-jsonc 1 0 0 1.41s
✅ JSON jsonlint 1 0 0.18s
✅ JSON prettier 1 1 0 0.94s
✅ JSON v8r 1 0 1.46s
❌ OPENAPI spectral 9 7 17.15s
✅ REPOSITORY git_diff yes no 0.77s
✅ REPOSITORY secretlint yes no 4.61s
❌ YAML yamllint 9 1 4.86s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@Kevsy
Copy link
Collaborator Author

Kevsy commented Feb 28, 2024

^ note the error above is the result of the linter running against the commit, i..e the linter files themselves.

@nicolacdnll
Copy link
Collaborator

I would like we get this PR merged sooner rather than later. Could we merge it?

What I see from the errors of the mega linter, most the issues are fixed by #222

Here a resume of the errors:

  • 83 issues with line-length
  • 37 issues with trailing-spaces
  • Some other issues:
  Error: 8:16 [colons] too many spaces after colon
  Error: 105:1 [empty-lines] too many blank lines (3 > 2)
  Warning: 375:9 [comments-indentation] comment not indented like content
  Error: 549:5 [indentation] wrong indentation: expected 6 but found 4
  Warning: 639:2 [comments-indentation] comment not indented like content
  Warning: 672:2 [comments-indentation] comment not indented like content
  Error: 743:10 [indentation] wrong indentation: expected 10 but found 9
  Error: 759:15 [indentation] wrong indentation: expected 10 but found 14
  Warning: 858:2 [comments-indentation] comment not indented like content
  Warning: 889:2 [comments-indentation] comment not indented like content
  Warning: 978:2 [comments-indentation] comment not indented like content
  Warning: 1540:2 [comments-indentation] comment not indented like content

@Kevsy
Copy link
Collaborator Author

Kevsy commented Mar 21, 2024

@nicolacdnll thanks and agree - you should be able to merge the PR (I can't merge because I created the PR)

@nicolacdnll nicolacdnll merged commit 689b171 into main Mar 21, 2024
1 check failed
@Kevsy Kevsy deleted the Kevsy-patch-9 branch March 21, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants