Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create EDS_API_Test.feature #120

Closed
wants to merge 3 commits into from
Closed

Create EDS_API_Test.feature #120

wants to merge 3 commits into from

Conversation

Kevsy
Copy link
Collaborator

@Kevsy Kevsy commented Jul 25, 2023

This PR adds a Gherkin feature file with tests for Simple Edge Discovery, as required by the Commonalities API Readiness Checklist

changed final scenario
Copy link
Collaborator

@gunjald gunjald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the EDSInvalidUEIdentity, can the error code "404 Not Found" be used instead of internal server error ?

@Kevsy
Copy link
Collaborator Author

Kevsy commented Aug 1, 2023

For the EDSInvalidUEIdentity, can the error code "404 Not Found" be used instead of internal server error ?

RFC9110 defines 404 Not Found as the suitable response code where "[...] the origin server did not find a current representation for the target resource". In this case the User Device Identity is not the target resource, rather it can be considered as an invalid parameter value.

While in some cases an invalid parameter value could be client error in the 4xx range (e.g wrong type), in the case of phone numbers and IP addresses the type syntax can be correct but not recognised by that operator (because of number portability and IP subnet changes). The 500 Internal Server Error allows us to provide details, as per RFC7807 and a common framework to do this is being considered by commonalities

Align with #127 and fix comment from initial review (404 instead of 500 for 'invalid device identifier')
@Kevsy
Copy link
Collaborator Author

Kevsy commented Aug 17, 2023

@gunjald on second thoughts, to align with Device Identifers and Quality on Demand APIs: I've made the 'EDSInvalidUEIdentity' a 404 as suggested above. It's technically not ideal for the reasons given, but at least it wil be consistent across CAMARA so probably the best option. I've update the .feature file accordingly (same Pull Request)

@Kevsy
Copy link
Collaborator Author

Kevsy commented Feb 9, 2024

Superseded by #201

@Kevsy Kevsy closed this Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants