Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TI API: resource modification while action is still in progress #291

Closed
FabrizioMoggio opened this issue Sep 9, 2024 · 2 comments
Closed
Labels
API improvement correction Suggesting corrections of API specification or indicating misalignment with API design guidelines documentation Indicating issues with API documentation or supplementary documents Fixed Traffic Influence API

Comments

@FabrizioMoggio
Copy link
Collaborator

Problem description

  • there is no error handling if the API Consumer invokes the TI API for the same Device-AppId if the previous requests are not completed yet.
  • the modification of the resource is expected to be done via PATCH but this is not well define din the documentation

Expected behavior

  • improve error handling considering to provide back an error code if the status of the previous action on that Device/AppId is not yet "active".
  • improve documentation
  • suggest to use Patch to modify a resource instead of creating a new one for the same Device-AppId

Additional context
If, the status of the first resource is "active" and the API Consumer, to modify the routing, instead of using a PATCH, creates a new resource with another POST, this is allowed and the new resource will overrule the previous one.

@FabrizioMoggio FabrizioMoggio added correction Suggesting corrections of API specification or indicating misalignment with API design guidelines documentation Indicating issues with API documentation or supplementary documents API improvement Traffic Influence API labels Sep 9, 2024
FabrizioMoggio added a commit to FabrizioMoggio/EdgeCloud that referenced this issue Sep 12, 2024
Resource modification while action is still in progress: camaraproject#291
@FabrizioMoggio
Copy link
Collaborator Author

Fixed with: #296

@FabrizioMoggio
Copy link
Collaborator Author

PR merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API improvement correction Suggesting corrections of API specification or indicating misalignment with API design guidelines documentation Indicating issues with API documentation or supplementary documents Fixed Traffic Influence API
Projects
None yet
Development

No branches or pull requests

1 participant