Corrections resolving linting errors #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolving linting errors
Linting - more
spaces removed for YAML linting
YAML spaces
line 42 space
rartych
requested review from
eric-murray,
bigludo7,
sachinvodafone and
akoshunyadi
as code owners
eric-murray
approved these changes
Dec 15, 2023
| @@ -99,7 +99,7 @@ info: | |||
| license: | |||
| name: Apache 2.0 | |||
| url: https://www.apache.org/licenses/LICENSE-2.0.html | |||
| version: 0.5.0-rc | |||
| version: 0.5.0-wip | |||
There was a problem hiding this comment.
I'm not familiar with the process, do we have to go back to wip and then make another PR for a release candidate?
There was a problem hiding this comment.
Yes, the idea is to prepare RC2 after applying changes based on feedback from the latest RC, so the "wip" distinguishes fluid version with ongoing changes from RC.
|
Added #95 as getting fixed by this PR to the description. |
akoshunyadi
approved these changes
Jan 22, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Proposed changes correct errors detected by:
The version was changed to:
0.5.0-wipWhich issue(s) this PR fixes:
Fixes #94 and #97
Special notes for reviewers:
The output of linting can be seen after expanding "Megalinter" section of workflow results:
https://github.com/rartych/DeviceStatus/actions/runs/7209051170/job/19639229860
Changelog input
Additional documentation
This section can be blank.