Clarification for initialEvent use in documentation #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarification for initialEvent & roaming event type
bigludo7
requested review from
eric-murray,
sachinvodafone and
akoshunyadi
as code owners
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
gmuratk
reviewed
Dec 23, 2024
|
|
||
| Following table illustrate behaviour regarding event triggering depending on **initial** reachability state of the device: | ||
|
|
||
| | subscrived event-type | device reachability status at subscription time | event send if ``initialEvent`` set to true | |
There was a problem hiding this comment.
minor typos in table header:
subscrived --> subscribed
event send --> event sent
gmuratk
reviewed
Dec 23, 2024
|
|
||
| Following table illustrate behaviour regarding event triggering depending on **initial** roaming state of the device: | ||
|
|
||
| | subscrived event-type | device roaming status at subscription time | event send if ``initialEvent`` set to true | |
There was a problem hiding this comment.
minor typos in table header:
subscrived --> subscribed
event send --> event sent
gmuratk
reviewed
Dec 23, 2024
|
|
||
| **Clarification on ``roaming-change-country`` event-type:** | ||
|
|
||
| ``roaming-change-country`` event is send only when the device stays in roaming situation and change country. |
Fix typos in table header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Clarify behavior of subscription/event server regarding use of initialEvent
Clarify roaming country change behavior
Which issue(s) this PR fixes:
Fixes #222
Special notes for reviewers:
Adding @gmuratk as reviewer.
Changelog input
Additional documentation
This section can be blank.