Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update device-status.yaml #111

Merged
merged 2 commits into from
Mar 13, 2024
Merged

Update device-status.yaml #111

merged 2 commits into from
Mar 13, 2024

Conversation

gmuratk
Copy link
Contributor

@gmuratk gmuratk commented Feb 8, 2024

Updating paths to align with Design Guidelines.

What type of PR is this?

  • correction

What this PR does / why we need it:

To comply with CAMARA API Design Guidelines.

Which issue(s) this PR fixes:

Fixes #96

Special notes for reviewers:

Changelog input

 release-note

Additional documentation

This section can be blank.

docs

Updating paths to align with Design Guidelines.
bigludo7
bigludo7 previously approved these changes Feb 14, 2024
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Time to make the change.

@akoshunyadi
Copy link
Collaborator

In the header, lines 54 and 58, there are still the old endpoints.

Replacing header lines based on new proposed endpoints
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akoshunyadi akoshunyadi merged commit 1427412 into camaraproject:main Mar 13, 2024
@akoshunyadi
Copy link
Collaborator

@gmuratk Sorry, during our Camara call I accidentally merged your PR, it should be only merged little later, after we branched for the 0.5.1. I reverted it, but now the PR is missing. Could you please recreate the PR? Thanks!

gmuratk added a commit to gmuratk/DeviceStatus-fix-path that referenced this pull request Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Path update per Design Guideline
4 participants