Use ObjectName as discriminator's mapping key #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…section of discriminators. Signed-off-by: Patrice Conil <[email protected]>
patrice-conil
requested review from
shilpa-padgaonkar,
rartych,
RubenBG7 and
jordonezlucena
as code owners
openapi --> OpenAPI
|
I have modified the style of writing OpenAPI name to be aligned with other parts of the DG: 4949c52 |
eric-murray
approved these changes
Oct 30, 2023
rartych
approved these changes
Nov 3, 2023
|
@RubenBG7 @jordonezlucena Could you review this PR? As it was discussed: it is recommendation to simplify life of developers using code generators. |
|
lgtm |
jordonezlucena
approved these changes
Nov 3, 2023
|
Merged as agreed in the call |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Encourage usage of Object Name as discriminator's mapping key to facilitate usage of Json serializer/deserializer
Which issue(s) this PR fixes:
Fixes #42
Special notes for reviewers:
Changelog input
Additional documentation