Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spectral rule to handle null values error in example fields #337

Merged
merged 5 commits into from
Dec 20, 2024

Conversation

ravindrapalaskar17
Copy link
Collaborator

@ravindrapalaskar17 ravindrapalaskar17 commented Nov 13, 2024

What type of PR is this?

  • Bug
  • Correction

What this PR does / why we need it:

Spectral rules failed while testing with Sim-swap repository:
camaraproject/SimSwap#153

Which issue(s) this PR fixes:

Fix the issue of below rules:

  1. camara-path-param-id
  2. camara-discriminator-use:

@rartych rartych added the correction correction in documentation label Nov 18, 2024
patrice-conil
patrice-conil previously approved these changes Nov 25, 2024
Copy link
Collaborator

@patrice-conil patrice-conil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

PedroDiez
PedroDiez previously approved these changes Dec 2, 2024
Copy link
Collaborator

@PedroDiez PedroDiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ravindrapalaskar17
Copy link
Collaborator Author

LGTM

@PedroDiez @patrice-conil Please have a look once again and approve the same as I have added the Changelog

PedroDiez
PedroDiez previously approved these changes Dec 11, 2024
Copy link
Collaborator

@PedroDiez PedroDiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Date correction
@rartych rartych merged commit 0270f54 into camaraproject:main Dec 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
correction correction in documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants